[getdns-api] Packaging getdns-api for RHEL/Fedora/CentOS

Paul Wouters paul at nohats.ca
Thu Feb 27 02:46:39 CET 2014


- It is a little confusing that the getdns-0.1.0.tar.gz contains
   specs/getdns-0.5.tgz. I suggest renaming that.

- make install does not honour DESTDIR= for the main Makefile.in
   (patch attached)

Package is up for review at: https://bugzilla.redhat.com/show_bug.cgi?id=1070510

Paul
-------------- next part --------------
diff -Naur getdns-0.1.0-orig/Makefile.in getdns-0.1.0/Makefile.in
--- getdns-0.1.0-orig/Makefile.in	2014-02-26 13:35:57.000000000 -0500
+++ getdns-0.1.0/Makefile.in	2014-02-26 20:13:26.499528071 -0500
@@ -48,17 +48,17 @@
 all : default
 
 install: all
-	$(INSTALL) -m 755 -d $(sharedoc)
-	$(INSTALL) -m 644 AUTHORS $(sharedoc)
-	$(INSTALL) -m 644 ChangeLog $(sharedoc)
-	$(INSTALL) -m 644 COPYING $(sharedoc)
-	$(INSTALL) -m 644 INSTALL $(sharedoc)
-	$(INSTALL) -m 644 LICENSE $(sharedoc)
-	$(INSTALL) -m 644 NEWS $(sharedoc)
-	$(INSTALL) -m 644 README.md $(sharedoc)
-	$(INSTALL) -m 755 -d $(sharedoc)/spec
-	$(INSTALL) -m 644 spec/index.html $(sharedoc)/spec
-	$(INSTALL) -m 644 spec/getdns*tgz $(sharedoc)/spec
+	$(INSTALL) -m 755 -d $(DESTDIR)/$(sharedoc)
+	$(INSTALL) -m 644 AUTHORS $(DESTDIR)/$(sharedoc)
+	$(INSTALL) -m 644 ChangeLog $(DESTDIR)/$(sharedoc)
+	$(INSTALL) -m 644 COPYING $(DESTDIR)/$(sharedoc)
+	$(INSTALL) -m 644 INSTALL $(DESTDIR)/$(sharedoc)
+	$(INSTALL) -m 644 LICENSE $(DESTDIR)/$(sharedoc)
+	$(INSTALL) -m 644 NEWS $(DESTDIR)/$(sharedoc)
+	$(INSTALL) -m 644 README.md $(DESTDIR)/$(sharedoc)
+	$(INSTALL) -m 755 -d $(DESTDIR)/$(sharedoc)/spec
+	$(INSTALL) -m 644 spec/index.html $(DESTDIR)/$(sharedoc)/spec
+	$(INSTALL) -m 644 spec/getdns*tgz $(DESTDIR)/$(sharedoc)/spec
 	cd src && $(MAKE) $@
 	cd doc && $(MAKE) $@
 	@echo "***"
@@ -79,7 +79,7 @@
 	@echo "***"
 
 uninstall:
-	rm -rf -d $(sharedoc)
+	rm -rf -d $(DESTDIR)/$(sharedoc)
 	cd doc && $(MAKE) $@
 	cd src && $(MAKE) $@
 
-------------- next part --------------
_______________________________________________
getdns-api mailing list
getdns-api at vpnc.org


More information about the spec mailing list