[getdns-users] [PATCH] Fix libversion numbering

Willem Toorop willem at nlnetlabs.nl
Tue May 12 22:23:31 CEST 2015


Op 12-05-15 om 18:16 schreef Daniel Kahn Gillmor:
> What happens if i pass the GETDNS_TRANSPORT_TLS_* constants to a version
> of libgetdns that doesn't know about them?  If they were silently
> accepted (i don't think this is the case), then this is definitely an
> ABI change, because the intended semantics of the underlying library
> function have shifted.  If they cause an error (which i think is what
> actually happens here, though i haven't tested) then you've got a
> stronger argument that the ABI is stable because the semantics are
> stable.

Good :)!  Because I can confirm that trying to set an undefined
transport has always resulted in an GETDNS_RETURN_CONTEXT_UPDATE_FAIL
return code and will still do this.

Thanks for raising this issue which eventually resulted in a more
consistently compiling library.

-- Willem



More information about the Users mailing list